Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests/README #6108

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

jkonecny12
Copy link
Member

Improve tests/README.rst file as it was awfully outdated.

This soft-depends on #6107 to be merged first.

A lot changed from the past when the text was written and this
documentation was not updated since.
The security advices were not correct. This is attempt to improve the
state.
@jkonecny12 jkonecny12 changed the title Main cleanup testing readme Improve tests/README Jan 23, 2025
@jkonecny12
Copy link
Member Author

/kickstart-test --waive docs only

It was header section and the podman command was hard to read. This
should improve the situation.
Let's put all the "how to containers" to one section with sub-sections.
@jkonecny12
Copy link
Member Author

/kickstart-test --waive docs only

Copy link
Contributor

@elkoniu elkoniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM but I am not sure if it is worth to split it into 5 separated commits. I would put it in the single commit with extended commit message.

@jkonecny12
Copy link
Member Author

I thought it will be easier to understand my intentions but I can definitely squash it.

@jkonecny12 jkonecny12 merged commit 3b04ab8 into rhinstaller:main Jan 24, 2025
17 checks passed
@jkonecny12
Copy link
Member Author

Ups I forgot about the merge before hitting the button. Hopefully, it's not that problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants